Skip to content

Conversation

@sheenaajay
Copy link
Contributor

@sheenaajay sheenaajay commented Apr 15, 2020

Request for a review.
1.Generated changelog
2.Generated References.
3.Modify the function examples to show in correct format
4.Acceptance tests running clean on github actions and travis
5.Unit tests running clean on travis(in github action its failing-ruby version is different in github 2.6.3 on travis 2.5.7)

Screen Shot 2020-04-16 at 08 59 13

Screen Shot 2020-04-16 at 08 59 45

@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #1102 into release will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           release   #1102      +/-   ##
==========================================
+ Coverage     4.58%   5.50%   +0.91%     
==========================================
  Files          185     185              
  Lines         5229    5229              
==========================================
+ Hits           240     288      +48     
+ Misses        4989    4941      -48     
Impacted Files Coverage Δ
lib/puppet/functions/stdlib/end_with.rb 0.00% <ø> (ø)
lib/puppet/functions/stdlib/start_with.rb 0.00% <ø> (ø)
lib/puppet/type/file_line.rb 96.36% <0.00%> (+1.81%) ⬆️
lib/puppet/provider/file_line/ruby.rb 62.62% <0.00%> (+47.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e80b4...791a956. Read the comment docs.

@david22swan david22swan merged commit 990cd99 into puppetlabs:release Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants