feat: use variable for postgresql locale #422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGodin-C2C
requested review from
bastelfreak,
smortex and
a team
as code owners
Signed-off-by: Julien Godin <[email protected]>
JGodin-C2C
force-pushed
the
use_variable_locale
branch
from
dd279e8 to
8b89a3e
Compare
JGodin-C2C
changed the title
|
/me gently waving in the general direction of @bastelfreak @smortex , |
|
Hi, |
smortex
reviewed
Jan 9, 2025
| @@ -63,7 +63,7 @@ | |||
| grant: 'all', | |||
| port: params[:database_port].to_i, | |||
| encoding: 'UTF8', | |||
| locale: 'en_US.UTF-8', | |||
| locale: params[:postgresql_locale], | |||
There was a problem hiding this comment.
postgresql_locale does not appear in the params definition, so I would expect CI to fail, let's see…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the breaking change introduced by 0c5c270 were the puppetdb can't be created on a system where the locale EN_us.UTF-8 is not installed.
This has been also reported in in #412 (comment)
C.UTF-8 seems a better choice in this case, I'm not a locales expert enough to say if it's the perfect choice.