Support rpm platforms without yum #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
observed the latest rockylinux 9 containers do not have a yum symlink to dnf anymore.
2 tasks
bastelfreak
approved these changes
May 13, 2024
jordanbreen28
approved these changes
May 14, 2024
donoghuc
reviewed
May 14, 2024
Contributor
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Should the default remain yum in the case both are present?
Contributor
Author
No, technically yum has been deprecated since EL8. Anytime it's present it should be preferred. |
donoghuc
approved these changes
May 14, 2024
Contributor
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Looks like PR tests are unrelated. This seems like a good change. thanks
gavindidrichsen
approved these changes
May 15, 2024
Contributor
gavindidrichsen
left a comment
gavindidrichsen
left a comment
There was a problem hiding this comment.
Looks good to me!
shubhamshinde360
added a commit
to shubhamshinde360/install-puppet
that referenced
this pull request
Jun 21, 2024
Changes from amazon renaming puppetlabs/puppetlabs-puppet_agent#721 and dnf support addition puppetlabs/puppetlabs-puppet_agent#717 have also aggregated here
shubhamshinde360
added a commit
to shubhamshinde360/install-puppet
that referenced
this pull request
Jun 21, 2024
Changes for dnf support addition puppetlabs/puppetlabs-puppet_agent#717 have also aggregated here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
observed the latest rockylinux 9 containers do not have a yum symlink to dnf anymore.
Related: