Allow order parameter to be string value #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concat::fragment accepts either a string or integer as order parameter value. Numeric ordering doesn't work once converted to string filenames: 20 sequential fragments for example | Numeric (no padding) | String (0 Zero Padded) | |----------------------|------------------------| | 10_fragment | 001_fragment | | 11_fragment | 002_fragment | | ... | | | 19_fragment | 010_fragment | | 1_fragment | 011_fragment | | 20_fragment | 012_fragment | | 2_fragment | 013_fragment | | 3_fragment | 014_fragment | Order has gone to pot...
|
Yes please. |
Contributor
Author
|
@derbious Hadn't noticed the ordering 'fix' in that file. I opened this PR because the current release didn't work with my existing configuration. RFC: Making order an integer deviates from concat::fragment allowing both integer and string? |
concat::fragment accepts either a string or integer as order parameter value. Numeric ordering doesn't work once converted to string filenames: 20 sequential fragments for example | Numeric (no padding) | String (0 Zero Padded) | |----------------------|------------------------| | 10_fragment | 001_fragment | | 11_fragment | 002_fragment | | ... | | | 19_fragment | 010_fragment | | 1_fragment | 011_fragment | | 20_fragment | 012_fragment | | 2_fragment | 013_fragment | | 3_fragment | 014_fragment | Order has gone to pot... @derbious adding rspec tests to check manage_pg_hba_conf w/ acls removing unneeded test
Contributor
|
@matonb Merged, thank you! |
diogokiss
pushed a commit
to Tradeshift/puppetlabs-postgresql
that referenced
this pull request
Jan 3, 2019
* Allow order parameter to be string value concat::fragment accepts either a string or integer as order parameter value. Numeric ordering doesn't work once converted to string filenames: 20 sequential fragments for example | Numeric (no padding) | String (0 Zero Padded) | |----------------------|------------------------| | 10_fragment | 001_fragment | | 11_fragment | 002_fragment | | ... | | | 19_fragment | 010_fragment | | 1_fragment | 011_fragment | | 20_fragment | 012_fragment | | 2_fragment | 013_fragment | | 3_fragment | 014_fragment | Order has gone to pot... * Allow order parameter to be string value concat::fragment accepts either a string or integer as order parameter value. Numeric ordering doesn't work once converted to string filenames: 20 sequential fragments for example | Numeric (no padding) | String (0 Zero Padded) | |----------------------|------------------------| | 10_fragment | 001_fragment | | 11_fragment | 002_fragment | | ... | | | 19_fragment | 010_fragment | | 1_fragment | 011_fragment | | 20_fragment | 012_fragment | | 2_fragment | 013_fragment | | 3_fragment | 014_fragment | Order has gone to pot... @derbious adding rspec tests to check manage_pg_hba_conf w/ acls removing unneeded test
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
* Allow order parameter to be string value concat::fragment accepts either a string or integer as order parameter value. Numeric ordering doesn't work once converted to string filenames: 20 sequential fragments for example | Numeric (no padding) | String (0 Zero Padded) | |----------------------|------------------------| | 10_fragment | 001_fragment | | 11_fragment | 002_fragment | | ... | | | 19_fragment | 010_fragment | | 1_fragment | 011_fragment | | 20_fragment | 012_fragment | | 2_fragment | 013_fragment | | 3_fragment | 014_fragment | Order has gone to pot... * Allow order parameter to be string value concat::fragment accepts either a string or integer as order parameter value. Numeric ordering doesn't work once converted to string filenames: 20 sequential fragments for example | Numeric (no padding) | String (0 Zero Padded) | |----------------------|------------------------| | 10_fragment | 001_fragment | | 11_fragment | 002_fragment | | ... | | | 19_fragment | 010_fragment | | 1_fragment | 011_fragment | | 20_fragment | 012_fragment | | 2_fragment | 013_fragment | | 3_fragment | 014_fragment | Order has gone to pot... @derbious adding rspec tests to check manage_pg_hba_conf w/ acls removing unneeded test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concat::fragment accepts either a string or integer as order parameter value.
Numeric ordering doesn't work once converted to string filenames:
20 sequential fragments for example
Order has gone to pot...