MODULES-2989 parameter ensure of custom resource postgresql_replication_slot is not documented #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelenCampbell
suggested changes
Jun 16, 2017
README.md
Outdated
|
|
||
| ##### `ensure` | ||
|
|
||
| Specifies the action to create or destroy named slot. Must be present |
Contributor
There was a problem hiding this comment.
Can you remove "Must be present" here and add "Required." as a line under the ensure title please?
README.md
Outdated
|
|
||
| Valid values: `present`, `absent`. | ||
|
|
||
| Default value: `present`. |
Contributor
There was a problem hiding this comment.
The values present and absent need to have single quotes around them instead of backticks.
fixed ' v ` issue from review
added required string instead of must be present
HelenCampbell
approved these changes
Jun 16, 2017
pmcmaw
requested changes
Jun 16, 2017
Contributor
pmcmaw
left a comment
pmcmaw
left a comment
There was a problem hiding this comment.
Can you move the 'Required.' to above the description and below the title. Eg something like this:
db
Required.
Sets the name of the database in which to create this schema.
pmcmaw
approved these changes
Jun 16, 2017
diogokiss
pushed a commit
to Tradeshift/puppetlabs-postgresql
that referenced
this pull request
Jan 3, 2019
…on_slot is not documented (puppetlabs#884) added required string instead of must be present
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
…on_slot is not documented (puppetlabs#884) added required string instead of must be present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MODULES-2989 parameter ensure of custom resource postgresql_replication_slot is not documented
updated the README.md appropriately