Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jul 5, 2024

Automated release-prep through pdk-templates from commit 7e46636.
Please verify before merging:

@github-actions github-actions bot requested a review from alexjfisher as a code owner July 5, 2024 08:55
@github-actions github-actions bot requested review from a team and bastelfreak as code owners July 5, 2024 08:55
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other breaking changes? should they be included?
#1625
#1624

@bastelfreak
Copy link
Collaborator

also there are other EoL operating systems in metadata.json, those should be removed as well.

@Ramesh7
Copy link
Contributor

Ramesh7 commented Jul 5, 2024

also there are other EoL operating systems in metadata.json, those should be removed as well.

Sure @bastelfreak, let me have look and take that forward. Thanks

@Ramesh7
Copy link
Contributor

Ramesh7 commented Jul 11, 2024

also there are other EoL operating systems in metadata.json, those should be removed as well.

Sure @bastelfreak, let me have look and take that forward. Thanks

Hi @bastelfreak, Have reviewed the list of platforms in the metadata file are supported. So I think we are good here.

bastelfreak
bastelfreak previously approved these changes Jul 11, 2024
@Ramesh7 Ramesh7 merged commit 12903a5 into main Jul 11, 2024
@Ramesh7 Ramesh7 deleted the release-prep branch July 11, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants