Allow any sensitive type so that Sensitive(Deferred(...)) values can be passed to concat::fragment #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Providing
Sensitive(Deferred(...))inputs toconcat::fragment(where the deferred function returns aString) does not work inconcat::fragment.Additional Context
Given that
Deferredtypes do work, it seems reasonable to allow these to also beSensitiveso you can handle things like secrets from Vault, orSensitivedeferred templates - however currently,concat::fragmentonly allowsSensitive[String], which can't be determined at compile time when there's aDeferredfunction to resolve.This PR generalises it to allow just
Sensitive; I appreciate this weakens the type-checking slightly, but allowingDeferredalready seems to have similar issues (because you can't tell that it's aDeferred[String]), so hopefully this is acceptable.Checklist
puppet apply)