Pin puppet-lint to 0.3.2 #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Why does the version need to be pinned? |
Contributor
Author
|
The new release of puppet-lint causes all of the modules to break. This module would have failed travis checks in #209 if they had been allowed to complete. We're pinning puppet-lint across all the supported modules until the changes to puppet-lint have been worked out. |
Contributor
|
@cmurphy I hadn't hit that yet. Sounds reasonable. I'm going to go ahead and merge it before travis finishes (or even starts) since it'll likely fail anyways. |
Contributor
Author
|
Well the point of this commit is to prevent it from failing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.