Skip to content

Conversation

@DavidS
Copy link
Contributor

@DavidS DavidS commented Jan 26, 2021

Update gha templates
pdk version: 1.19.0.pre (47)

@DavidS DavidS requested a review from a team as a code owner January 26, 2021 17:25
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, recently I saw https://github.com/FragileTech/bump-version and that uses pure YAML as an action. It's on my agenda to see if this can be used to avoid syncing these complex workflows to every repo.

@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #2118 (13f55bd) into main (0c19106) will decrease coverage by 1.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
- Coverage   57.40%   56.36%   -1.05%     
==========================================
  Files          12       12              
  Lines         216      220       +4     
==========================================
  Hits          124      124              
- Misses         92       96       +4     
Impacted Files Coverage Δ
lib/facter/apache_version.rb 55.00% <ø> (ø)
lib/puppet/functions/apache/apache_pw_hash.rb 0.00% <ø> (ø)
lib/puppet/functions/apache/bool2httpd.rb 0.00% <0.00%> (ø)
lib/puppet/functions/apache/pw_hash.rb 0.00% <ø> (ø)
lib/puppet/functions/apache_pw_hash.rb 0.00% <ø> (ø)
lib/puppet/functions/bool2httpd.rb 0.00% <ø> (ø)
lib/puppet/provider/a2mod.rb 31.57% <ø> (ø)
lib/puppet/provider/a2mod/a2mod.rb 61.11% <ø> (ø)
lib/puppet/provider/a2mod/gentoo.rb 93.84% <ø> (ø)
lib/puppet/provider/a2mod/modfix.rb 75.00% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443888c...13f55bd. Read the comment docs.

@DavidS DavidS closed this Jan 26, 2021
@DavidS DavidS reopened this Jan 26, 2021
@DavidS
Copy link
Contributor Author

DavidS commented Jan 27, 2021

restarted travis with repo checksum errors

@DavidS
Copy link
Contributor Author

DavidS commented Jan 27, 2021

Btw, recently I saw https://github.com/FragileTech/bump-version and that uses pure YAML as an action. It's on my agenda to see if this can be used to avoid syncing these complex workflows to every repo.

No argument here. Github has dropped the ball on making Actions good for larger organisations. Let's be real, we're only using them because Puppet already pays for it. I've looked at gitlab a couple of times, and a gitlab instance would provide some significant benefits to our CI implementation.

@sanfrancrisko sanfrancrisko merged commit c1a830b into main Jan 27, 2021
@sanfrancrisko sanfrancrisko deleted the pdksync_gha-updates branch January 27, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants