Skip to content

Allow relative paths in oidc_redirect_uri #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2020
Merged

Allow relative paths in oidc_redirect_uri #2082

merged 3 commits into from
Nov 4, 2020

Conversation

@sanfrancrisko
Copy link
Contributor

@sanfrancrisko sanfrancrisko commented Nov 3, 2020

This PR takes psaiz's work in #2076 and also adds unit tests.

Closes #2076

@sanfrancrisko sanfrancrisko requested a review from a team as a code owner November 3, 2020 22:00
@sanfrancrisko sanfrancrisko reopened this Nov 3, 2020
@sanfrancrisko sanfrancrisko reopened this Nov 4, 2020
@david22swan david22swan merged commit 935acd4 into puppetlabs:main Nov 4, 2020
@sanfrancrisko sanfrancrisko deleted the feat/main/odic_redirect_relative_uri branch November 4, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@carabasdaniel carabasdaniel carabasdaniel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carabasdaniel carabasdaniel

@david22swan david22swan

@sanfrancrisko sanfrancrisko

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanfrancrisko @carabasdaniel @david22swan @psaiz