Skip to content

Commit 54ad2fd

Browse files
committed
Replace Debian 6 tests with Debian 8
Debian 6 is no longer supported according to metadata.json so it doesn't make sense to test it. Debian 8 is. This cleans it up.
1 parent 4817d83 commit 54ad2fd

File tree

7 files changed

+19
-41
lines changed

7 files changed

+19
-41
lines changed

spec/classes/apache_spec.rb

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
describe 'apache', type: :class do
66
context 'on a Debian OS' do
7-
include_examples 'Debian 6'
7+
include_examples 'Debian 8'
88

99
it { is_expected.to contain_class('apache::params') }
1010
it {
@@ -17,7 +17,7 @@
1717
it { is_expected.to contain_group('www-data') }
1818
it { is_expected.to contain_class('apache::service') }
1919
it {
20-
is_expected.to contain_file('/var/www').with(
20+
is_expected.to contain_file('/var/www/html').with(
2121
'ensure' => 'directory',
2222
)
2323
}
@@ -46,7 +46,7 @@
4646
).that_notifies('Class[Apache::Service]')
4747
}
4848
# Assert that load files are placed and symlinked for these mods, but no conf file.
49-
['auth_basic', 'authn_file', 'authz_default', 'authz_groupfile', 'authz_host', 'authz_user', 'dav', 'env'].each do |modname|
49+
['auth_basic', 'authn_file', 'authz_groupfile', 'authz_host', 'authz_user', 'dav', 'env'].each do |modname|
5050
it {
5151
is_expected.to contain_file("#{modname}.load").with(
5252
'path' => "/etc/apache2/mods-available/#{modname}.load",
@@ -232,22 +232,13 @@
232232
end
233233
end
234234

235-
context '8' do
236-
include_examples 'Debian 8'
237-
238-
it {
239-
is_expected.to contain_file('/var/www/html').with(
240-
'ensure' => 'directory',
241-
)
242-
}
243-
describe 'Alternate mpm_modules when declaring mpm_module => prefork' do
244-
let :params do
245-
{ mpm_module: 'worker' }
246-
end
247-
248-
it { is_expected.to contain_exec('/usr/sbin/a2dismod event') }
249-
it { is_expected.to contain_exec('/usr/sbin/a2dismod prefork') }
235+
describe 'Alternate mpm_modules when declaring mpm_module => prefork' do
236+
let :params do
237+
{ mpm_module: 'worker' }
250238
end
239+
240+
it { is_expected.to contain_exec('/usr/sbin/a2dismod event') }
241+
it { is_expected.to contain_exec('/usr/sbin/a2dismod prefork') }
251242
end
252243

253244
context 'on Ubuntu 14.04' do

spec/classes/mod/auth_gssapi_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
context 'default configuration with parameters' do
99
context 'on a Debian OS', :compile do
10-
include_examples 'Debian 6'
10+
include_examples 'Debian 8'
1111

1212
it { is_expected.to contain_class('apache::params') }
1313
it { is_expected.to contain_apache__mod('auth_gssapi') }

spec/classes/mod/auth_kerb_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
context 'default configuration with parameters' do
99
context 'on a Debian OS', :compile do
10-
include_examples 'Debian 6'
10+
include_examples 'Debian 8'
1111

1212
it { is_expected.to contain_class('apache::params') }
1313
it { is_expected.to contain_apache__mod('auth_kerb') }

spec/classes/mod/info_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,10 @@ def general_info_specs_apache24
124124
it_behaves_like 'a mod class, without including apache'
125125

126126
context 'On a Debian OS' do
127-
include_examples 'Debian 6'
127+
include_examples 'Debian 8'
128128

129129
# Load the more generic tests for this context
130-
general_info_specs_apache22
130+
general_info_specs_apache24
131131

132132
it {
133133
is_expected.to contain_file('info.conf').with(ensure: 'file',

spec/classes/mod/mime_magic_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def general_mime_magic_specs
1111
it_behaves_like 'a mod class, without including apache'
1212

1313
context 'On a Debian OS with default params' do
14-
include_examples 'Debian 6'
14+
include_examples 'Debian 8'
1515

1616
general_mime_magic_specs
1717

@@ -58,7 +58,7 @@ def general_mime_magic_specs
5858
end
5959

6060
context 'with magic_file => /tmp/magic' do
61-
include_examples 'Debian 6'
61+
include_examples 'Debian 8'
6262

6363
let :params do
6464
{ magic_file: '/tmp/magic' }

spec/classes/mod/status_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,13 @@ def require_directives(requires)
6868
it_behaves_like 'a mod class, without including apache'
6969

7070
context 'default configuration with parameters' do
71-
context 'on a Debian 6 OS' do
72-
include_examples 'Debian 6'
71+
context 'on a Debian 8 OS' do
72+
include_examples 'Debian 8'
7373

7474
context 'with default params' do
7575
it { is_expected.to contain_apache__mod('status') }
7676

77-
include_examples 'status_conf_spec', ['127.0.0.1', '::1'], 'On', '/server-status'
77+
include_examples 'status_conf_spec_require', 'ip 127.0.0.1 ::1', 'On', '/server-status'
7878

7979
it {
8080
is_expected.to contain_file('status.conf').with(ensure: 'file',
@@ -98,7 +98,7 @@ def require_directives(requires)
9898

9999
it { is_expected.to compile }
100100

101-
include_examples 'status_conf_spec', ['10.10.10.10', '11.11.11.11'], 'Off', '/custom-status'
101+
include_examples 'status_conf_spec_require', 'ip 10.10.10.10 11.11.11.11', 'Off', '/custom-status'
102102
end
103103

104104
context "with valid parameter type $allow_from => ['10.10.10.10']" do

spec/spec_helper_local.rb

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,19 +37,6 @@
3737
let(:facts) { on_supported_os['debian-8-x86_64'] }
3838
end
3939

40-
shared_context 'Debian 6' do
41-
let :facts do
42-
{
43-
id: 'root',
44-
kernel: 'Linux',
45-
osfamily: 'Debian',
46-
operatingsystem: 'Debian',
47-
operatingsystemrelease: '6',
48-
path: '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
49-
}
50-
end
51-
end
52-
5340
shared_context 'Debian 8' do
5441
let(:facts) { on_supported_os['debian-8-x86_64'] }
5542
end

0 commit comments

Comments
 (0)