Remove OS fact differences in proxy_connect_spec

Using `it_behaves_like` creates a new scope and runs those tests in them.
`a mod class, including apache` is a shared context and doesn't contain
any tests. When using `include_examples`, you can actually inherit the
context.

It then goes a step further and reuses that context in every test. This
works because the Apache version is a parameter so it doesn't matter.

After that, nothing refers to the Debian 7 facts anymore and can be
cleaned up.

Author: ekohl

spec/classes/mod/proxy_connect_spec.rb

@@ -9,37 +9,33 @@
     ]
   end
 
-  it_behaves_like 'a mod class, without including apache'
-  context 'on a Debian OS' do
-    context 'with Apache version < 2.2' do
-      include_examples 'Debian 7'
-      let :params do
-        {
-          apache_version: '2.1',
-        }
-      end
+  include_examples 'a mod class, without including apache'
 
-      it { is_expected.not_to contain_apache__mod('proxy_connect') }
+  context 'with Apache version < 2.2' do
+    let :params do
+      {
+        apache_version: '2.1',
+      }
     end
-    context 'with Apache version = 2.2' do
-      include_examples 'Debian 7'
-      let :params do
-        {
-          apache_version: '2.2',
-        }
-      end
 
-      it { is_expected.to contain_apache__mod('proxy_connect') }
+    it { is_expected.not_to contain_apache__mod('proxy_connect') }
+  end
+  context 'with Apache version = 2.2' do
+    let :params do
+      {
+        apache_version: '2.2',
+      }
     end
-    context 'with Apache version >= 2.4' do
-      include_examples 'Debian 8'
-      let :params do
-        {
-          apache_version: '2.4',
-        }
-      end
 
-      it { is_expected.to contain_apache__mod('proxy_connect') }
+    it { is_expected.to contain_apache__mod('proxy_connect') }
+  end
+  context 'with Apache version >= 2.4' do
+    let :params do
+      {
+        apache_version: '2.4',
+      }
     end
+
+    it { is_expected.to contain_apache__mod('proxy_connect') }
   end
 end

spec/spec_helper_local.rb

@@ -50,19 +50,6 @@
   end
 end
 
-shared_context 'Debian 7' do
-  let :facts do
-    {
-      id: 'root',
-      kernel: 'Linux',
-      osfamily: 'Debian',
-      operatingsystem: 'Debian',
-      operatingsystemrelease: '7.0.0',
-      path: '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
-    }
-  end
-end
-
 shared_context 'Debian 8' do
   let(:facts) { on_supported_os['debian-8-x86_64'] }
 end