(PUP-10854) allow apt to install local packages

[ciprianbadescu]

Before puppet-18.0, using an absolute path as package name allowed
users to install local packages using apt. While this was working,
the functionality was unintended and incomplete(eg. puppet will execute
package install command each run and will report changes).

This commit enables the usage of source parameter with apt provider
and now a user can install a local package using a manifest like bellow:

package { 'helloworld':
    source => '/tmp/helloworld_1.0-1.deb'
    ensure => installed,
}

[gimmyxd]

Might be better to provide some info if the manifest has ensure => 1.2.3, source => /path/to/packge. In this case i would assume the version is ignored.

[ciprianbadescu]

I added check to allow only :present and :installed for ensure when using source parameter

[ciprianbadescu]

This could not be good enough since we may need a way to handle package upgrades

[ciprianbadescu]

what if we pass through ensure value and in case source file was specified, we make sure the expected version was installed (this is what yum provider does in all cases):

puppet/lib/puppet/provider/package/apt.rb

Lines 165 to 174 in c0e007a

	# If a source file was specified, we must make sure the expected version was installed from specified file
	if source
	is = self.query
	raise Puppet::Error, _("Could not find package %{name}") % { name: self.name } unless is
	version = is[:ensure]
	raise Puppet::Error, _("Failed to update to version %{should}, got version %{version} instead") % { should: should, version: version } unless
	insync?(version)
	end

[gimmyxd]

I think this could work and it would be consistent.

[gimmyxd]

why do we need !should.is_a?(Symbol)?

[ciprianbadescu]

if the install command was successful, the package should have been installed, extra-check is not needed in case if :present or :installed values
we do extra-checks only in case specific version was requested

[gimmyxd]

Rather than relying on object type, maybe we should check the actual values.