(PUP-7526) Adds pip2 provider

[jglenn9k]

As Python2 is being deprecated, users need a way to migrate to Python3. The default provider => 'pip' should be using Python3. This MR does not make that change. This MR is an intermediate step to allow users to explicitly use Python2 pip.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[jglenn9k]

CI failure due to the commit message having a . after the bug number. Not sure how to fix that...

[puppetcla]

Waiting for CLA signature by @jglenn9k

@jglenn9k - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

[luchihoratiu]

Hi @jglenn9k,

Thank you for your code contribution! I've changed your pull request's title to something that respects our template as shown below:

You should do the same change to the commit ( just a matter of executing a git commit --amend, editing the commit summary as needed and then finally git push --forceing the changes). CI should pass after that 😄 .

[luchihoratiu]

LGTM! Manually tested this on Ubuntu 20.04 and works as expected.

Only one more thing before merging this: please add the pull request's description in the commit summary and change the commit title from (PUP-7526) Add pip2 provider. to (PUP-7526) Add pip2 provider. We usually don't finish commit titles with a full stop.

[jglenn9k]

LGTM! Manually tested this on Ubuntu 20.04 and works as expected.

Only one more thing before merging this: please add the pull request's description in the commit summary and change the commit title from (PUP-7526) Add pip2 provider. to (PUP-7526) Add pip2 provider. We usually don't finish commit titles with a full stop.

Done. I personally tested this on Ubuntu 18.04 LTS against Puppet 5.5.20 and 6.18.0.

[GabrielNagy]

Hi @jglenn9k,

The main branch corresponds to our next major release (Puppet 7). If you want to also have this in the next Puppet 6 release (6.19.0) you should change the base branch of this PR to master instead. The commit will then auto-promote to the main branch as well, when CI passes.

Thanks!

[jglenn9k]

I guess that's a fresh Pull Request? #8311

[GabrielNagy]

I guess that's a fresh Pull Request? #8311

That's fine too. For reference, you can also change the base branch of an existing pull request, and then rebase your commit on top of the new branch.

See: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-base-branch-of-a-pull-request

[GabrielNagy]

Closing in favor of #8311