(PUP-10227) Preserve expectation for http.finish #7980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stub the "Net::HTTP#started?" method so finish happens as expected. Protect against Net::HTTP#finish being called twice, and ensure the "Closing connection" debug message is printed after the redirect, since Pool#close_connection will be a noop.
joshcooper
force-pushed
the
stub_finish
branch
from
a1b5052 to
9b8a2a2
Compare
melissa
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stub the "Net::HTTP#started?" method so finish happens as expected. Protect
against Net::HTTP#finish being called twice, and ensure the "Closing connection"
debug message is printed after the redirect, since Pool#close_connection will be
a noop.