(maint) document the 'other' set_server_facts #7961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magisus
approved these changes
Feb 4, 2020
Contributor
Magisus
left a comment
Magisus
left a comment
There was a problem hiding this comment.
Thanks for doing this. The PR checks are going to fail with the SERVER ticket tag; if we're not okay with that, perhaps this should be (maint).
mwaggett
approved these changes
Feb 4, 2020
Document the other set_server_facts in puppetserver.
tkishel
force-pushed
the
SERVER-2724_server_facts_for_cat_v4
branch
from
878e49f to
6007375
Compare
tkishel
changed the title
joshcooper
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the other set_server_facts in puppetserver,
to reduce the chance of them being out of sync.