(PUP-1537) add mark property for package #7815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
Contributor
Author
|
jenkins please test this on |
Dorin-Pleava
approved these changes
Nov 26, 2019
GabrielNagy
reviewed
Jan 8, 2020
lib/puppet/type/package.rb
Outdated
| warning "\"ensure=>held\" has been deprecated and will be removed in a future version, use \"mark=hold\" instead " | ||
| end | ||
| if @parameters[:mark] && [:absent, :purged, :held].include?(@parameters[:ensure].should) | ||
| raise ArgumentError, _("You cannot use \"mark\" property while \"ensure\" is one of [\"absent\", \"purged\", \"held\"]") |
Contributor
There was a problem hiding this comment.
Maybe wrap this string in single quotes to avoid escaping the double quotes inside
acceptance/tests/provider/package/dpkg_hold_true_package_is_latest.rb
Outdated
Show resolved
Hide resolved
acceptance/tests/provider/package/dpkg_hold_true_should_preserve_version.rb
Outdated
Show resolved
Hide resolved
ciprianbadescu
force-pushed
the
PUP-1537/dpkg-mark-hold-feature
branch
from
811e06a to
4cfd26b
Compare
ciprianbadescu
force-pushed
the
PUP-1537/dpkg-mark-hold-feature
branch
2 times, most recently
from
a1e5685 to
2db477f
Compare
This commit adds `mark` property for package providers on Debian(dpkg/apt/fink/aptitude) and Solaris(pgk) as alternative of using "held" value for `ensure`. Using "held" value for `ensure` works as before, but it shows deprecation warning and will be removed in further release. Allowed values for `mark` are "hold/none", default to "none". Mark can be specified with or without `ensure`, if `ensure` is missing it will default to "present". Mark cannot be specified together with "purged", "absent" or "held" values for `ensure`.
ciprianbadescu
force-pushed
the
PUP-1537/dpkg-mark-hold-feature
branch
from
2db477f to
b6ab169
Compare
Contributor
|
Kicking Travis |
Contributor
|
jenkins please test this on |
GabrielNagy
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
markproperty for package providers onDebian(dpkg/apt/fink/aptitude) and Solaris(pgk) as
alternative of using "held" value for
ensure.Using "held" value for
ensureworks as before, but it showsdeprecation warning and will be removed in further release.
Allowed values for
markare "hold/none", default to "none".Mark can be specified with or without
ensure, ifensureismissing it will default to "present".
Mark cannot be specified together with "purged", "absent" or "held"
values for
ensure.