(PUP-9356) Allow loading local content for local puppet device modes
#7282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in PUP-8766/puppetlabs#7242 removed plugin loading from a local environment for `puppet device`, even in the cases where local content is supposed to be used. This change reverts the part of puppetlabs#7242 that was causing this. By allowing puppet to load local content for '--apply', '--facts' and '--resource', those run modes can now work stand alone again.
da-ar
approved these changes
Dec 11, 2018
da-ar
left a comment
da-ar
left a comment
There was a problem hiding this comment.
Verified that this fixes the broken tests in RSAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in PUP-8766/#7242 removed plugin loading from a local
environment for
puppet device, even in the cases where local contentis supposed to be used.
This change reverts the part of #7242 that was causing this. By allowing
puppet to load local content for '--apply', '--facts' and '--resource',
those run modes can now work stand alone again.