-
Notifications
You must be signed in to change notification settings - Fork 43
(FM-8079) Resource API and Transports Hands-on-Lab #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| 1. [Download PDK](https://puppet.com/download-puppet-development-kit) on your platform of choice. | ||
|
|
||
| 2. If you do not have a Philips HUE hub available, you can download the [Hue-Emulator](https://github.com/SteveyO/Hue-Emulator/raw/master/HueEmulator-v0.8.jar). You need to have Java installed to run this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is hub the right word here? Or is it meant to be bulb? If it's correct please ignore!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming it's fine as it's used throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In truth, you'd need both the hub and the bulbs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to say that? Or is it fine in this instance to just say hub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll also add "and bulbs" for clarity.
|
|
||
| ## Hue Emulator | ||
|
|
||
| Download the [HueEmulator-v0.8.jar](https://github.com/SteveyO/Hue-Emulator/blob/master/HueEmulator-v0.8.jar) from [SteveyO/Hue-Emulator](https://github.com/SteveyO/Hue-Emulator). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't they have already done this in the installing section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a duplicate, yeah.
| @@ -0,0 +1,19 @@ | |||
| ## Implementing the transport - Exercise | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidS I'm confused, what is the difference between this section and 'Implementing the transport' below? The other one seems like it is the exercise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional exercise steps that can be used to deepen the reader's understanding and comfort with the code. They're not necessary for completing the Lab. This section here contains hints to help folks along.
|
@DavidS I've finished an initial copy edit of this, but I'll take another look when it's complete. When you do plane to finish the TODO parts? Thanks! |
| # Add a new transport | ||
|
|
||
| [Eventually](https://github.com/puppetlabs/pdk/pull/666) there will be a `pdk new transport`, for now you'll need to copy in a few files for this workshop. | ||
| [Eventually](https://github.com/puppetlabs/pdk/pull/666) there will be a `pdk new transport` command. For now, you'll need to copy the files below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been released with pdk 1.12.0
DavidS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clairecadman changes look good to me.
* clarify that, yes, bulbs are needed, too * remove duplicate java and emulator install instructions * update "Add a new transport" section to use released pdk feature
de524fa to
71a8e0b
Compare
|
Rebased and finalized. |
No description provided.