Add flexible Linux box support for Vagrant #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmil
force-pushed
the
vagrant_detect_service_restart
branch
from
1172ab7 to
c9fd9de
Compare
Determining the SSH service restart command needed based on the Vagrant box name containing one of the expected sequences is problematic. With this change the required service restart command should be automatically determined for at least all vaguely recent Debian, Ubuntu, EL, or Suse systems, regardless of box name.
seanmil
force-pushed
the
vagrant_detect_service_restart
branch
from
c9fd9de to
07f15ef
Compare
david22swan
approved these changes
Oct 17, 2023
Member
david22swan
left a comment
david22swan
left a comment
There was a problem hiding this comment.
The change look's good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determining the SSH service restart command needed based on the Vagrant box name containing one of the expected sequences is problematic. With this change the required service restart command should be automatically determined for at least all vaguely recent Debian, Ubuntu, EL, or Suse systems, regardless of box name.