(FACT-3102) Use non-deprecated YAML safe loading #2496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR suppresses the following `Psych.safe_load` args warn when using
Psych 3.1.0 (Ruby 2.6+).
Passing permitted_classes with the 2nd argument of Psych.safe_load
is deprecated. Use keyword argument like Psych.safe_load(yaml,
permitted_classes: ...) instead.
This is needed because in Psych 4 (included in Ruby 3.1) it is no longer
allowed to use the non-keyword style.
|
Can one of the admins verify this patch? |
|
Perhaps I should have used FACT-3123 instead. |
bastelfreak
reviewed
Jun 23, 2022
| res = nil | ||
| begin | ||
| res = YAML.safe_load(output, [Symbol, Time]) | ||
| res = if Gem::Version.new(Psych::VERSION) >= Gem::Version.new('3.1.0') # Ruby 2.6+ |
There was a problem hiding this comment.
We used the exact fix in other places, for example bolt. 👍 from my side.
bastelfreak
approved these changes
Jun 23, 2022
joshcooper
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses the following
Psych.safe_loadargs warn when using Psych 3.1.0 (Ruby 2.6+).This is needed because in Psych 4 (included in Ruby 3.1) it is no longer allowed to use the non-keyword style.
An alternative to #2484