(maint) Fix plan show for project plans #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bolt plan show <plan>` was failing when passed a project-level
plan due to the fact that the project path is a Pathname rather than a
string, unlike most modules. We now convert the path to a string in
`get_plan_info` so that any code interacting with the plan data can
treat it as if it came from any other module.
!bug
* **Fix `bolt plan show <plan>` for project-level plans**
([puppetlabs#1799](puppetlabs#1799))
This command was throwing errors due to a type mismatch that is now
resolved.
nicklewis
force-pushed
the
bolt-plan-show-project-plans
branch
from
58c059a to
9912525
Compare
|
CLA signed by all contributors. |
beechtom
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bolt plan show <plan>was failing when passed a project-levelplan due to the fact that the project path is a Pathname rather than a
string, unlike most modules. We now convert the path to a string in
get_plan_infoso that any code interacting with the plan data cantreat it as if it came from any other module.
!bug
bolt plan show <plan>for project-level plans(#1799)
This command was throwing errors due to a type mismatch that is now
resolved.