(BOLT-1379) (docs) 'file upload' can handle directories

[caseywilliams]

Update the string docs for the upload_file boltlib function to mention
that the function is able to upload directories as well as files.

[caseywilliams]

Appveyor failure looks unrelated (I hope)?

[puppetcla]

CLA signed by all contributors.

[donoghuc]

We generate https://github.com/puppetlabs/bolt/blob/master/pre-docs/plan_functions.md with a rake task based on puppet-strings documentation in plan function definitions. You can run bundle exec rake docs and commit the markdown. (Travis is failing because the markdown is not up to date with strings source

bolt/.travis.yml

Lines 52 to 57 in 46434af

	- |
	if ! bundle exec rake docs; then
	false
	elif ! git diff --exit-code; then
	false
	fi

).

I was looking for places in the docs where we may clarify this, but I think it is missing. Maybe we could add it to:

https://github.com/puppetlabs/bolt/blob/master/pre-docs/bolt_command_reference.md#bolt-command-reference
https://github.com/puppetlabs/bolt/blob/df2bffe56a3fa3b144bcb121c3fea6750bd55fa2/pre-docs/running_bolt_commands.md#upload-files-to-remote-nodes

[adreyer]

unfortunately this needs a ticket or it won't get copy pasted into the real docs

[caseywilliams]

Ok, thanks both - I've created a JIRA ticket and regenerated the markdown, and added mentions of directories in several other places.

[caseywilliams]

I'm not sure I understand why Travis is failing

[donoghuc]

@casey it is unrelated to this PR. We have a regression in the puppet-resource_api gem. We are working on a fix for now. Thanks!

[donoghuc]

I think this logging/outputting is intended more to map to the action file upload rather than describe to the user the behavior of the action. I would lean toward leaving that part out and instead just focus on documenting what to expect with file upload.

[caseywilliams]

Ok, removed the executor changes