(MODULES-6608) - Updates to support newer versions of bolt

[pmcmaw]

The --insecure parameter was replaced in Bolt v 0.16.0. In order for our
tests to run against different versions of bolt it requires the
following changes. This also unpins us from testing on Bolt 0.7.0. We
will now test on the latest version of bolt.

These changes have been tested on the following variations to ensure the correct flag is passed through:

ffi v 1.9.18
bolt v 0.7.0

ffi v 1.9.18
bolt v 0.16.0

[pmcmaw]

The following is an example of what was used to test the combination of versions and was placed in the spec_helper_acceptance of mysql.

package { 'ffi' :
provider => 'puppet_gem',
ensure   => '1.9.18',
}

package { 'bolt' :
provider => 'puppet_gem',
ensure   => '0.7.0',
}
EOS

create_remote_file(default, '/tmp/gems.pp', pp)
on default, puppet('apply', '/tmp/gems.pp'), acceptable_exit_codes: [0, 1]`

[tphoney]

using the latest version is not a great idea, due to the churn that bolt is still going through. it would be better to pin to a known good version.

The method https://github.com/puppetlabs/beaker-task_helper/blob/master/lib/beaker/task_helper.rb#L21 allows users of the module to specify a version, if needs be

Otherwise good. we should change the pinned version away from '0.7.0' but to a specific version

[pmcmaw]

Cool @tphoney, a bolt release is being worked on and will include a fix for the ffi issues (pins to a healthier version). Hopefully it should be released at some point today. Do you have any objections pinning to it when it is released? I will test it locally before getting it merged and released.

[pmcmaw]

Fix has been tested on mysql (redhat5) and exec (debian-8-x64).