-
Notifications
You must be signed in to change notification settings - Fork 112
Move examples into separate folders. #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Single docker-compose that uses and environment variable to load the matching example. Upside: re-use of docker compose config. Downside: tiny bit of magic to newcomers and newer examples might require more elaborate docker compose config for them to make sense/work.
See below (both answers). On one hand examples should be self-contained, on the other hand, Docker and Envoy might add unnecessary compexity as well...
- Do we want a separate
Cargo.toml
files for each example or go with Rust standard approach? It sounds like co-locating (dev-)dependencies was preferred to "avoid" the rustsec vuln fromchrono
from the main Crate? It would likely require more extensive changes and transition to a workspace.
I'd prefer a separate Cargo.toml
and src/lib.rs
(since it has to be a cdylib
for now), so that each example is a self-contained crate that users can copy as a base and evolve into their own plugins.
Working cargo build --examples
would be great, but that's a secondary concern.
- To what extend does
raze
need to be involved? For devs coming from a mostly Rust background that could be tooling they are unfamiliar with.
Agreed, Bazel integration adds a ton of complexity that isn't strictly necessary. Maybe let's ignore it for now in examples.
FWIW, we can probably land this after v0.2.0 (unless you want to clear cargo-audit
warnings in dependent crates?).
I think this would be fine to land after 0.2, just so we don't block the WASM reactor change going out. Will allow us to iterate a bit and land on a solid implementation we are all happy with. In addition, would enable you to bring in your uncommitted examples. edit: having an rustsec ignore on a devDependency of an example is not the worst. |
I'll start from this perspective and migrate each example. Having an |
d2d3f2d
to
c20d1c9
Compare
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Martijn Swaagman <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
4cf8495
to
eac15dc
Compare
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
c8fcd64
to
af9fe67
Compare
Signed-off-by: Piotr Sikora <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It was removed in proxy-wasm#146. Signed-off-by: Piotr Sikora <[email protected]>
Bazel examples were removed in proxy-wasm#146. Signed-off-by: Piotr Sikora <[email protected]>
* Restore Bazel example to verify working rules_rust. Bazel examples were removed in #146. Signed-off-by: Piotr Sikora <[email protected]> * review: strip debuginfo. Signed-off-by: Piotr Sikora <[email protected]> --------- Signed-off-by: Piotr Sikora <[email protected]>
Migrate examples to separate folders.
TODO:
(and perhaps run?)cargo audit
eachcargo.toml
for examplesEarlier draft PR discussion
Cargo.toml
files for each example or go with Rust standard approach? It sounds like co-locating (dev-)dependencies was preferred to "avoid" the rustsec vuln fromchrono
from the main Crate? It would likely require more extensive changes and transition to a workspace.raze
need to be involved? For devs coming from a mostly Rust background that could be tooling they are unfamiliar with.fixes #140
fixes #35 by showing how
dispatch_http_call
works