Skip to content

Fix typos in Bazel function names. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Fix typos in Bazel function names. #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
895bfb6
Change the name to use "sdk" instead of "host"
ingwonsong Jul 14, 2022
0a09686
Change "host" to "sdk" in WORKSPACE
ingwonsong Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
workspace(name = "proxy_wasm_cpp_sdk")

load("@proxy_wasm_cpp_sdk//bazel:repositories.bzl", "proxy_wasm_cpp_host_repositories")
load("@proxy_wasm_cpp_sdk//bazel:repositories.bzl", "proxy_wasm_cpp_sdk_repositories")

proxy_wasm_cpp_host_repositories()
proxy_wasm_cpp_sdk_repositories()

load("@proxy_wasm_cpp_sdk//bazel:dependencies.bzl", "proxy_wasm_cpp_host_dependencies")
load("@proxy_wasm_cpp_sdk//bazel:dependencies.bzl", "proxy_wasm_cpp_sdk_dependencies")

proxy_wasm_cpp_host_dependencies()
proxy_wasm_cpp_sdk_dependencies()

load("@proxy_wasm_cpp_sdk//bazel:dependencies_extra.bzl", "proxy_wasm_cpp_host_dependencies_extra")
load("@proxy_wasm_cpp_sdk//bazel:dependencies_extra.bzl", "proxy_wasm_cpp_sdk_dependencies_extra")

proxy_wasm_cpp_host_dependencies_extra()
proxy_wasm_cpp_sdk_dependencies_extra()
4 changes: 2 additions & 2 deletions bazel/dependencies.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
load("@emsdk//:deps.bzl", emsdk_deps = "deps")

# Requires proxy_wasm_cpp_host_repositories() to be loaded first.
def proxy_wasm_cpp_host_dependencies():
# Requires proxy_wasm_cpp_sdk_repositories() to be loaded first.
def proxy_wasm_cpp_sdk_dependencies():
protobuf_deps()
emsdk_deps()
4 changes: 2 additions & 2 deletions bazel/dependencies_extra.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@

load("@emsdk//:emscripten_deps.bzl", "emscripten_deps")

# Requires proxy_wasm_cpp_host_dependencies() to be loaded first.
def proxy_wasm_cpp_host_dependencies_extra():
# Requires proxy_wasm_cpp_sdk_dependencies() to be loaded first.
def proxy_wasm_cpp_sdk_dependencies_extra():
emscripten_deps()
2 changes: 1 addition & 1 deletion bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")

def proxy_wasm_cpp_host_repositories():
def proxy_wasm_cpp_sdk_repositories():
maybe(
http_archive,
name = "emsdk",
Expand Down