Make VERSION tuple numeric. #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
force-pushed
the
VERSION-numerique
branch
from
90e0624 to
ce9beec
Compare
Note that by being numeric we drop the rc/a/b/dev suffix. I'm also adding the pep440 regular expression to make sure the version number match the spec. The pep 440 spec is a bit annoying with the fact that a/b/rc don't have dots, but .dev do. There are some issues if you don't follow the spec and publish both whl/tgz, as pip will mix-up the values, and think the tgz are actually a more recent version than the whl. It may be fixed in setuptools/pip, but better be safe. Ii did not go the route of setting VERSION and having __version__ be a '.'.join() as setup.py use regex to extract version number. Maye docs/conf.py could also use the same trick as setup.py to avoid having to update the version number in multiple places ? Closes prompt-toolkit#1707
Carreau
force-pushed
the
VERSION-numerique
branch
from
ce9beec to
b29727e
Compare
|
Yeah, it's better to add before committing.... Rebased/squashed and force pushed. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that by being numeric we drop the rc/a/b/dev suffix. I'm also adding the pep440 regular expression to make sure the version number match the spec.
The pep 440 spec is a bit annoying with the fact that a/b/rc don't have dots, but .dev do.
There are some issues if you don't follow the spec and publish both whl/tgz, as pip will mix-up the values, and think the tgz are actually a more recent version than the whl. It may be fixed in setuptools/pip, but better be safe.
Ii did not go the route of setting VERSION and having version be a '.'.join() as setup.py use regex to extract version number.
Maye docs/conf.py could also use the same trick as setup.py to avoid having to update the version number in multiple places ?
Closes #1707