Handle HTTP API error responses #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Renberg Tamm <[email protected]>
tgwizard
force-pushed
the
handle-http-api-error-responses
branch
from
0d5805f to
0dafc9a
Compare
|
Thanks 💚 |
|
@yaacov would you mind releasing this as v0.6.4? |
Merged
v0.6.4 released 🎉 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we query the Prometheus HTTP API with an invalid query, or there are other errors, the
run_commandorquery_rangemethods just return nil. E.g. for the response{"status": "error", "error": "1:6: parse error: unexpected identifier \"a\""}This PR ensures we check the
statusfield in the response body, which should besuccesson successful responses, and raisesRequestErrorotherwise. Based on https://prometheus.io/docs/prometheus/latest/querying/api/.I think some way of distinguishing good requests/responses from bad is nice, and given that there's already an exception here, perhaps we can reuse it?
@yaacov