This repository was archived by the owner on Mar 8, 2023. It is now read-only.
Convert HAProxy Exporter to using const metrics #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusv
force-pushed
the
const-metrics
branch
3 times, most recently
from
748066b to
dcfba92
Compare
|
Very nice. I'm not crazy about moving to an un-released version of client_golang, but the testing ability is great. |
SuperQ
reviewed
Dec 6, 2018
juliusv
force-pushed
the
const-metrics
branch
from
dcfba92 to
06e5f33
Compare
Signed-off-by: Julius Volz <[email protected]>
This also required completely re-doing the tests using the excellent CollectAndCompare() from the new client_golang, which uncovered a bug in HAProxy exporter when scraping old HAProxy versions that did not have all CSV fields (some metrics would be randomly missing in the output because we broke out of a loop in a non-deterministic way). Fixes #43 Signed-off-by: Julius Volz <[email protected]>
juliusv
force-pushed
the
const-metrics
branch
from
06e5f33 to
068eada
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also required completely re-doing the tests using the excellent
CollectAndCompare() from the new client_golang, which uncovered a bug in
HAProxy exporter when scraping old HAProxy versions that did not have all CSV
fields (some metrics would be randomly missing in the output because we broke
out of a loop in a non-deterministic way).
Fixes #43
Signed-off-by: Julius Volz [email protected]