Fix client TLS certificate tests #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGH-
force-pushed
the
fix-client-ca-tests
branch
3 times, most recently
from
4e5688d to
83566fc
Compare
|
Hello, this is now conflicting, could you please rebase? Thanks! |
client_ca_file is used to validate client certificate. However, in tests, client never present any. Signed-off-by: WGH <[email protected]>
Add tests cases when the client actually sends a certificate, and check
how the server responds to it.
The client certificates were generated with this command:
openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -keyout client2_selfsigned.key -out client2_selfsigned.pem -nodes -subj '/CN=test2' -days 36500 -addext "extendedKeyUsage = clientAuth"
Signed-off-by: WGH <[email protected]>
WGH-
force-pushed
the
fix-client-ca-tests
branch
from
83566fc to
04a477e
Compare
Done! Sorry that I couldn't get around rebasing earlier, considering that there weren't any major conflicts |
|
Thanks! |
chodges15
added a commit
to chodges15/exporter-toolkit
that referenced
this pull request
Jan 10, 2023
The changed certs were updated based on the command @WGH- in prometheus#61, just with an added SAN DNS. They were generated with this command: openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -keyout client2_selfsigned.key -out client2_selfsigned.pem -nodes -subj '/CN=test3' -days 36500 -addext "subjectAltName = DNS:test3" -addext "extendedKeyUsage = clientAuth" Signed-off-by: chodges15 <[email protected]>
chodges15
added a commit
to chodges15/exporter-toolkit
that referenced
this pull request
Mar 1, 2023
The changed certs were updated based on the command @WGH- in prometheus#61, just with an added SAN DNS. They were generated with this command: openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -keyout client2_selfsigned.key -out client2_selfsigned.pem -nodes -subj '/CN=test3' -days 36500 -addext "subjectAltName = DNS:test3" -addext "extendedKeyUsage = clientAuth" Signed-off-by: chodges15 <[email protected]>
chodges15
added a commit
to chodges15/exporter-toolkit
that referenced
this pull request
Mar 1, 2023
The changed certs were updated based on the command @WGH- in prometheus#61, just with an added SAN DNS. They were generated with this command: openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -keyout client2_selfsigned.key -out client2_selfsigned.pem -nodes -subj '/CN=test3' -days 36500 -addext "subjectAltName = DNS:test3" -addext "extendedKeyUsage = clientAuth" Signed-off-by: chodges15 <[email protected]>
chodges15
added a commit
to chodges15/exporter-toolkit
that referenced
this pull request
Mar 27, 2023
The changed certs were updated based on the command @WGH- in prometheus#61, just with an added SAN DNS. They were generated with this command: openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -keyout client2_selfsigned.key -out client2_selfsigned.pem -nodes -subj '/CN=test3' -days 36500 -addext "subjectAltName = DNS:test3" -addext "extendedKeyUsage = clientAuth" Signed-off-by: chodges15 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, in lots of existing tests,
client_ca_filewas set to the CA of the server. However, it's actually used to verify the client certificate, but there're no tests where the client presents any.In the second commit, I add a couple of tests where the client actually presents a certificate.