Prevent user enumeration #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2021 11:50
This commit makes sure that the timing is similar when a user exists or does not exist. Signed-off-by: Julien Pivotto <[email protected]>
Signed-off-by: Julien Pivotto <[email protected]>
Merged
stokito
pushed a commit
to stokito/exporter-toolkit
that referenced
this pull request
Jun 6, 2022
Add a `node_ethtool_info` metric to all ethtool devices to expose driver information with following labels: * bus_info * driver * expansion_rom_version * firmware_version * version This metric is useful to monitor the firmware version to be up-to-date. Note: The version label might be malformed due to bug prometheus#39 in ethtool: safchain/ethtool#39 Signed-off-by: Benjamin Drung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure that the timing is similar when a user exists or
does not exist.
Signed-off-by: Julien Pivotto [email protected]