Cache basic authentications #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the general approach is fine I will add specific tests. |
roidelapluie
force-pushed
the
fastauth
branch
from
51efd36 to
cec006b
Compare
roidelapluie
commented
Jan 14, 2021
SuperQ
reviewed
Jan 14, 2021
roidelapluie
force-pushed
the
fastauth
branch
from
5f139e5 to
75ce0a4
Compare
SuperQ
reviewed
Jan 15, 2021
In order to improve the response time with basic authentication, cache the results of bcrypt in memory. This is a draft to see if that approach would be acceptable. The code is coming from Caddy, and I have fullfiled the attribution required by Apache-2 by adding the copyright to our headers: caddyserver/caddy@9a7756c Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
force-pushed
the
fastauth
branch
from
75ce0a4 to
817d7e4
Compare
|
is this good to go? |
|
Hold on. |
added 2 commits
January 16, 2021 15:57
Add getters and setters Add a lock around bcrypt Fix the unhappy scenario Signed-off-by: Julien Pivotto <[email protected]>
Signed-off-by: Julien Pivotto <[email protected]>
|
OK now it works as expected. I have added getters and setters to release locks early. I have also added a Lock around bcrypt so that we only run one at the same time. |
beorn7
reviewed
Jan 16, 2021
| logger log.Logger | ||
| cache *cache | ||
| // bcryptMtx is there to ensure that bcrypt.CompareHashAndPassword is run | ||
| // only once in parallel as this is CPU expansive. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve the response time with basic authentication, cache
the results of bcrypt in memory.
This is a draft to see if that approach would be acceptable.
The code is coming from Caddy, and I have fullfiled the attribution
required by Apache-2 by adding the copyright to our headers:
caddyserver/caddy@9a7756c
Signed-off-by: Julien Pivotto [email protected]