Why not use the http.DefaultTransport of go sdk as the api.DefaultTransport value

[snakorse]

Currently, the DefaultRoundTripper in file client_golang/api/client.go creates a different http.Transport with fewer parameters set compared to http.DefaultTransport.

And there are some parameters that may help with reducing the total live connections, such as:

- ForceAttemptHTTP2:     true,
- IdleConnTimeout:       90 * time.Second

So, the question is: Could we simply use the http.DefaultTransport of go sdk as api.DefaultRoundTripper value? Is there any other consideration preventing this change?

var DefaultRoundTripper http.RoundTripper = http.DefaultTransport

[bwplotka]

There is -- reusing global variable is prone to surprises when people change their globals (implicitly or explicitly). Perhaps rarely happens, but...happens.

Feel free to add those new parameters (might have been newly added in Go). We can also write a quick test to ensure params are equal as http.Default (literally cmp.Diff(DefaultRoundTripper, http.DefaultTransport) == "").

Thanks for finding those new params!

[karthikkondapally]

There is -- reusing global variable is prone to surprises when people change their globals (implicitly or explicitly). Perhaps rarely happens, but...happens.

Feel free to add those new parameters (might have been newly added in Go). We can also write a quick test to ensure params are equal as http.Default (literally cmp.Diff(DefaultRoundTripper, http.DefaultTransport) == "").

Thanks for finding those new params!

@bwplotka instead of adding variable why do not we simply clone http.DefaultTransport for future sake. i.e some thing like below

var DefaultRoundTripper http.RoundTripper = func() http.RoundTripper {
 
   if t, ok := http.DefaultTransport.(*http.Transport); ok {
        cloned := t.Clone()

        // should we even apply these ?
        cloned.Proxy = http.ProxyFromEnvironment
        cloned.DialContext = (&net.Dialer{
            Timeout:   30 * time.Second,
            KeepAlive: 30 * time.Second,
        }).DialContext
        cloned.TLSHandshakeTimeout = 10 * time.Second

        return cloned
    }

    //  Fallback (extremely unlikely, but safe) or should we panic
    return http.DefaultTransport 
}()

[bwplotka]

Interesting. We could, but we risk breaking our users if the Go team decides to change something surprising. I guess we could trust Go team here, they are strict with breaking changes so I think I would be ok 👍