fix parsing include databases #521
Conversation
Signed-off-by: Paul van der Linden <[email protected]>
pvanderlinden
force-pushed
the
fix-auto-discovery
branch
from
f8a71d9 to
ffa6782
Compare
|
Should we add some tests for this? |
|
It probably should have some tests. I haven't had the time yet to check how the testing works, or how to setup some databases (as the current tests don't do that just yet). |
|
@SuperQ Are there any documentation on how to run the integration tests locally? |
|
Sorry, I don't know about either question. I'm not an expert in PG nor this exporter's codebase. It's an adopted project, not something from the core Prometheus team. |
Signed-off-by: Paul van der Linden <[email protected]>
pvanderlinden
force-pushed
the
fix-auto-discovery
branch
from
7198ef1 to
bc97291
Compare
|
I have added a basic integration test for this, and basic instructions for running the tests. It might need improvement, but it solves the current bug and adds a very simple test for it. |
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
LGTM, Thanks! This is great.
…to-discovery fix parsing include databases
2 participants
The introduction of the include databases flag disables the auto discovery flag completely, this PR will fix that.