-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: position_agent: Enforce type of x and y #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| agent = SchellingAgent((x, y), self, agent_type) | ||
| self.grid.position_agent(agent, (x, y)) | ||
| self.grid.position_agent(agent, x, y) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug where in the Schelling example, the number of agents in the scheduler does not match the number of agents in the space.
Codecov ReportBase: 91.32% // Head: 91.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
==========================================
- Coverage 91.32% 91.20% -0.13%
==========================================
Files 15 15
Lines 1303 1307 +4
Branches 223 225 +2
==========================================
+ Hits 1190 1192 +2
- Misses 80 81 +1
- Partials 33 34 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
It seems to me that |
Yes, I wanted to say this but forgot to send the message. |
|
LGTM... glad we Kaunta identified, thanks for fixing @rht |
No description provided.