Skip to content

Conversation

@rht
Copy link
Contributor

@rht rht commented Nov 6, 2022

No description provided.


agent = SchellingAgent((x, y), self, agent_type)
self.grid.position_agent(agent, (x, y))
self.grid.position_agent(agent, x, y)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug where in the Schelling example, the number of agents in the scheduler does not match the number of agents in the space.

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 91.32% // Head: 91.20% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (e064f42) compared to base (c7ec7b4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
- Coverage   91.32%   91.20%   -0.13%     
==========================================
  Files          15       15              
  Lines        1303     1307       +4     
  Branches      223      225       +2     
==========================================
+ Hits         1190     1192       +2     
- Misses         80       81       +1     
- Partials       33       34       +1     
Impacted Files Coverage Δ
mesa/space.py 95.72% <100.00%> (-0.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tortar
Copy link
Contributor

Tortar commented Nov 6, 2022

It seems to me that position_agent should be deprecated because everything can be done just by place_agent and move_to_empty, to me it doesn't make much sense to have also position_agent

@rht
Copy link
Contributor Author

rht commented Nov 6, 2022

It seems to me that position_agent should be deprecated because everything can be done just by place_agent and move_to_empty, to me it doesn't make much sense to have also position_agent

Yes, I wanted to say this but forgot to send the message.

@tpike3
Copy link
Member

tpike3 commented Nov 6, 2022

LGTM... glad we Kaunta identified, thanks for fixing @rht

@tpike3 tpike3 merged commit bfca50c into projectmesa:main Nov 6, 2022
@rht rht deleted the position_agent branch November 6, 2022 12:26
@tpike3 tpike3 added this to the Mesa 2.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants