doc: Document requirements for pre-launched VM #8703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
For a pre-launched VM, it is essential to include 'reboot=acpi' in the 'bootargs' of the scenario.xml file. Additionally, if the VM is named VM0, the grub.cfg file must contain 'module2 /boot/ACPI_VM0.bin ACPI_VM0'. Currently, several scenario files located in misc/config_tools/data already support 'reboot=acpi'. Furthermore, the postinst Debian script automatically adds the 'module2' command to grub.cfg if the scenario is 'partitioned'. Therefore, by using the provided scenarios, the pre-launched VM can be used without any additional configuration. However, when using a custom scenario file, there is a risk of omitting the necessary parameter and command for a pre-launched VM. To avoid such errors, it is useful to document these requirements. Signed-off-by: Daichi Fukui <[email protected]>
|
start to build |
|
@daichifukui Thanks for your patch. But ACPI support is not essential for a pre-launched VM, also current pre-launched VM does not support VM level reboot. |
|
start to run premerge test |
jsun26intel
reviewed
Sep 2, 2025
| are automatically launched at boot time by the hypervisor. The User VMs can | ||
| be Real-Time VMs (RTVMs), Safety VMs, or standard User VMs. | ||
|
|
||
| When selecting this scenario, ensure that ``reboot=acpi`` is included in the |
There was a problem hiding this comment.
The document here is for ACRN High-Level Architecture. The scenario doesn't care the RTVM OS is Linux or others. But your patch specifies the "reboot=acpi" cmdline which works for Linux only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
For a pre-launched VM, it is essential to include 'reboot=acpi' in the 'bootargs' of the scenario.xml file. Additionally, if the VM is named VM0, the grub.cfg file must contain
'module2 /boot/ACPI_VM0.bin ACPI_VM0'.
Currently, several scenario files located in misc/config_tools/data already support 'reboot=acpi'. Furthermore, the postinst Debian script automatically adds the 'module2' command to grub.cfg if the scenario is 'partitioned'. Therefore, by using the provided scenarios, the pre-launched VM can be used without any additional configuration.
However, when using a custom scenario file, there is a risk of omitting the necessary parameter and command for a pre-launched VM. To avoid such errors, it is useful to document these requirements.
Hence this pull request.
I'd appreciate it if you could review this request and merge it with the upstream.