Skip to content

ci: remove intel from image updates in odh sync workflow #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

ci: remove intel from image updates in odh sync workflow #801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/odh-notebooks-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ jobs:
python-version: ${{ env.PYTHON_VERSION }}
cache: 'pipenv'

# Sync fails with pipenv 2024.1.0 (current latest version)
# TODO: We should retry with later versions of pipenv once they are available.
- name: Install pipenv and pip-versions
run: pip install pipenv==2024.0.3 pip-versions
run: pip install pipenv==2024.4.0 pip-versions

- name: Update Pipfiles in accordance with Codeflare-SDK latest release
run: |
Expand All @@ -74,7 +72,7 @@ jobs:
# replace existing version of cf-sdk with new version in Pipfile
sed -i "s/codeflare-sdk = .*$/codeflare-sdk = \"~=$CODEFLARE_RELEASE_VERSION\"/g" Pipfile
# Lock dependencies, ensuring pre-release are included and clear previous state
if ! pipenv lock --pre --clear ; then
if ! pipenv lock --verbose --pre --clear ; then
echo "Failed to lock dependencies"
exit 1
fi
Expand All @@ -98,7 +96,8 @@ jobs:
echo "Version ${CODEFLARE_RELEASE_VERSION} is available for $package_name"
# list all Pipfile paths having Codeflare-SDK listed
# Extracting only directories from file paths, excluding a `.gitworkflow` and `.git` directory
directories+=($(grep --exclude-dir=.git --exclude-dir=.github --include="Pipfile*" -rl "${package_name} = \"~=.*\"" | xargs dirname | sort | uniq))
# Extracting Intel directories as they are not supported in RHOAI
directories+=($(grep --exclude-dir=.git --exclude-dir=.github --exclude-dir=intel --exclude-dir=jupyter/intel --include="Pipfile*" -rl "${package_name} = \"~=.*\"" | xargs dirname | sort | uniq))
counter=0
total=${#directories[@]}
for dir in "${directories[@]}"; do
Expand Down
Loading