Skip to content

Fix Dashboard URI returned by cluster.status() #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Fix Dashboard URI returned by cluster.status() #317

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41fdba9
Fix Dashboard URI returned by cluster.status()
ChristianZaccaria Aug 21, 2023
2af2b7a
Merge branch 'main' into fix-dashboard-uri
KPostOffice Aug 30, 2023
224ffc5
Merge branch 'main' into fix-dashboard-uri
KPostOffice Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/codeflare_sdk/cluster/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ def cluster_dashboard_uri(self) -> str:

for route in routes["items"]:
if route["metadata"]["name"] == f"ray-dashboard-{self.config.name}":
return f"http://{route['spec']['host']}"
protocol = "https" if route["spec"].get("tls") else "http"
return f"{protocol}://{route['spec']['host']}"
return "Dashboard route not available yet, have you run cluster.up()?"

def list_jobs(self) -> List:
Expand Down Expand Up @@ -585,7 +586,8 @@ def _map_to_ray_cluster(rc) -> Optional[RayCluster]:
ray_route = None
for route in routes["items"]:
if route["metadata"]["name"] == f"ray-dashboard-{rc['metadata']['name']}":
ray_route = route["spec"]["host"]
protocol = "https" if route["spec"].get("tls") else "http"
ray_route = f"{protocol}://{route['spec']['host']}"

return RayCluster(
name=rc["metadata"]["name"],
Expand Down