Skip to content

Conversation

@max123kl
Copy link
Contributor

@max123kl max123kl commented Sep 6, 2019

No description provided.

@ben
Copy link
Member

ben commented Sep 6, 2019

I see that this fixes a bug in the GitHub renderer, but it looks like the HTML and PDF versions don't suffer from this bug. Can you verify that this will render correctly in those formats?

@max123kl
Copy link
Contributor Author

max123kl commented Sep 6, 2019

I'm sorry, I don't have the experience to do this.

@tabathap
Copy link

👌

@yugaego
Copy link
Contributor

yugaego commented Nov 23, 2020

I confirm this PR fixes the issue. See the screenshots below. Tested on the latest master: 14ab61c.

Note that wrapping this asterisk into plus signs, as was suggested by Asciidoctor maintainer, also fixes the issue with the same results as shown below.

On master

HTML
before-html

EPUB
before-epub

PDF
before-pdf

With the PR fix

HTML
after-html

EPUB
after-epub

PDF
after-pdf

@ben
Copy link
Member

ben commented Nov 23, 2020

Lovely, thanks so much, everybody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants