add passing options #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o execute_async method
|
Thanks for the contribution @Tom1204, could you add some tests to ensure passing kwargs and options works as expected. |
… headers key conflict in passing arguments
|
Test has been added @xkludge, I have also fixed keyword argument conflicts |
|
@xkludge have you had a time to look on it? |
Sorry for the late reply. I am reviewing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add passing options(Ex: timeout, verify_ssl, ...aiohttp parameters) to execute_async method
What kind of change does this PR introduce?
feature
What is the current behavior?
Can not pass additional options to async request
What is the new behavior?
Can pass additional options to async request
Does this PR introduce a breaking change?
No
Other information