Skip to content

Fixing #46 by adding an optional argument to disable riase_for_status #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing #46 by adding an optional argument to disable riase_for_status #55

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e90e332
Fixing #46 by adding an optional argument to disable riase_for_status
sferich888 Mar 27, 2023
56b1a9c
Merge branch 'master' into master
xkludge Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python_graphql_client/graphql_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ def execute(
variables: dict = None,
operation_name: str = None,
headers: dict = {},
riase_for_status: bool = True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By chance did you mean?

Suggested change
riase_for_status: bool = True,
raise_for_status: bool = True,

**kwargs: Any,
):
"""Make synchronous request to graphQL server."""
Expand All @@ -50,8 +51,10 @@ def execute(
headers={**self.headers, **headers},
**{**self.options, **kwargs},
)

if riase_for_status:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if riase_for_status:
if raise_for_status:

result.raise_for_status()

result.raise_for_status()
return result.json()

async def execute_async(
Expand Down