Add ability to override init_payload for subscriptions. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add init_payload parameter to GraphqlClient.subscribe() allowing override of payload sent in connection_init call to peer when initializing the socket.
|
@Pelleplutt Thanks you for contributing to the project. It looks good to me overall but can you format your code with Black so that it can pass our CI? Alternatively, you can use pre-commit as guided in CONTRIBUTING.md. I would also appreciate it if you could update the unit tests to account for your changes. |
|
Sure, sorry for not doing my homework. Basic test added, formatting cleaned up. I refrained from making a negative corresponding test in the TestGraphqlClientSubscriptions.test_headers_passed_to_websocket_connect() test as it felt superflous, let me know if you disagree. |
DaleSeo
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add init_payload parameter to GraphqlClient.subscribe() allowing
override of payload sent in connection_init call to peer when
initializing the socket.
What kind of change does this PR introduce?
Minor feature add to allow override of payload when setting up the subscription socket. I have found this useful as some gql subscriptions require information such as tokens etc. in this initial payload. Change should be backwards_compatible.