Skip to content

Conversation

DaleSeo
Copy link
Contributor

@DaleSeo DaleSeo commented Nov 9, 2020

What kind of change does this PR introduce?

Release

What is the current behavior?

version 0.3.1

What is the new behavior?

version 0.3.2

Also updated CHANGELOG.md to reflect the changes we've made so far.

@DaleSeo DaleSeo requested review from steve148 and xkludge November 9, 2020 18:45
@DaleSeo DaleSeo self-assigned this Nov 9, 2020
Copy link
Contributor

@steve148 steve148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@steve148 steve148 self-requested a review November 9, 2020 19:29
@steve148
Copy link
Contributor

steve148 commented Nov 9, 2020

@DaleSeo Sorry for the review / removing the review. Should this release count as a patch or as a minor version change?

@DaleSeo
Copy link
Contributor Author

DaleSeo commented Nov 9, 2020

@steve148 On second thought, I'd rather see this as a minor release as it includes API changes though they're unlikely to be breaking changes. Are we on the same page?

@steve148
Copy link
Contributor

@DaleSeo we are, this definitely feels like a minor patch, so it should be 0.4.0.

@DaleSeo
Copy link
Contributor Author

DaleSeo commented Nov 10, 2020

Agreed to release a minor version. Closing in favor of #35

@DaleSeo DaleSeo closed this Nov 10, 2020
@steve148 steve148 deleted the release/0.3.2 branch November 10, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants