-
Notifications
You must be signed in to change notification settings - Fork 21
Subscription headers #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription headers #30
Conversation
headers are added to the websockets connect method keep alive message is handled without crashing
Thanks @DrWacker, could you run black on the project and add a test for the functionality you added. Thanks! |
@DrWacker Regarding the formatting issue, please refer to the following contributing guide. Pre-commit hook will automatically format your code changes. It would be great if you could write unit tests for the bug fix but it wouldn't be necessary. |
Dale,
I'll be happy to try that. Having trouble getting things working with my
work computer but will try again later on my personal machine.
Thank you for reaching out.
Taylor
…On Mon, Oct 12, 2020 at 2:44 PM Dale Seo ***@***.***> wrote:
@DrWacker <https://github.com/DrWacker> Regarding the formatting issue,
please refer to the following contributing guide. Pre-commit hook will
automatically format your code changes.
https://github.com/prodigyeducation/python-graphql-client/blob/master/docs/CONTRIBUTING.md#getting-started
It would be great if you could write unit tests for the bug fix but it's
wouldn't be necessary.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQGWOX2AQISDQWQOJMQ5DTSKNTDPANCNFSM4SNH2TXA>
.
|
@@ -3,7 +3,7 @@ repos: | |||
rev: stable | |||
hooks: | |||
- id: black | |||
language_version: python3.7 | |||
language_version: python3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python3.8 is required for IsolatedAsyncioTestCase so I changed it here as well
@DaleSeo @xkludge I don't know why black is failing in the pipeline. I'm getting green on my screen. Do either of you have any debugging tips? > git commit -am "added unit test" Nevermind. Just ran black manually. |
@DrWacker It seems like there's a bit of discrepancy between our tooling. I tried to run Black locally. Please refer to the following feedback from Black. |
@DaleSeo if I'm looking at your output correctly my most recent push now matches that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DrWacker Thanks for fixing formatting issues and adding unit tests! The code looks great!
@DrWacker I'll create a PR to bump the version now. Once it gets merged, the new version will show up in Pypi in a couple of minutes or so. |
@DaleSeo Thanks! |
headers are added to the websockets connect method
keep alive message is handled without crashing
What kind of change does this PR introduce?
This feature allows the passing of header information in the subscribe method. Also it handles a keep alive message
What is the current behavior?
#28
What is the new behavior?
See changes comment above
Does this PR introduce a breaking change?
Nope
Other information
N/A