Skip to content

Conversation

davepagurek
Copy link
Contributor

@davepagurek davepagurek commented Sep 19, 2025

This is another attempt at what #8098 is trying to do. In #8094 (comment) @limzykenneth noticed that the updates to global mode function binding were clashing with how FES parameter validation currently works: methods on global mode now cache the functions they're wrapping for efficiency, but they were caching them before FES got added.

This PR tries to do this by passing proxies into addon registration and lifecycle methods. If you assign something to a p5 instance or the p5 prototype, this will now re-bind the global to the window.

There's a chance that in a lifecycle method like presetup, an addon will define a function (like FES does) that it adds to the instance, but that additionally captures and uses this, which will now be a proxy to the instance. When this is used within that function, it could be assigning and reassigning to state properties. We don't want the overhead of making those global every time, so I've added an inLifecycle variable that tracks when we're inside e.g. presetup and then turns false afterwards, letting us check that and stop binding new globals once we're out of that lifecycle.

Test sketch: https://editor.p5js.org/davepagurek/sketches/tlH_eIBUn

@limzykenneth
Copy link
Member

I'll try to review this tomorrow

@limzykenneth
Copy link
Member

I've figured out a way to do function decoration for FES, will see if we fully need these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants