Re-bind globals when assigned in addons #8099
Open
+202
−162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at what #8098 is trying to do. In #8094 (comment) @limzykenneth noticed that the updates to global mode function binding were clashing with how FES parameter validation currently works: methods on global mode now cache the functions they're wrapping for efficiency, but they were caching them before FES got added.
This PR tries to do this by passing proxies into addon registration and lifecycle methods. If you assign something to a p5 instance or the p5 prototype, this will now re-bind the global to the window.
There's a chance that in a lifecycle method like
presetup
, an addon will define a function (like FES does) that it adds to the instance, but that additionally captures and usesthis
, which will now be a proxy to the instance. Whenthis
is used within that function, it could be assigning and reassigning to state properties. We don't want the overhead of making those global every time, so I've added aninLifecycle
variable that tracks when we're inside e.g.presetup
and then turns false afterwards, letting us check that and stop binding new globals once we're out of that lifecycle.Test sketch: https://editor.p5js.org/davepagurek/sketches/tlH_eIBUn