move deploy process to github actions #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outofambit
commented
Feb 15, 2021
Member
|
hi @outofambit this is great!! what's the status on this? are there other steps needed before we make the switch? |
Contributor
Author
|
@lmccart i needed to do some testing to make sure what i wrote was right, and now i have (and fixed a bunch of bugs) so this is ready on my end to merge! feedback welcome if anyone has on what i did here! (i updated the PR description with the highlights) |
outofambit
commented
Mar 13, 2021
limzykenneth
approved these changes
Mar 14, 2021
lmccart
approved these changes
Mar 15, 2021
Member
lmccart
left a comment
lmccart
left a comment
There was a problem hiding this comment.
This looks good to me. I'll leave it here and you can merge when you're ready to test and make the next release @outofambit. Sound good? Just ping me if you'd like and I can be on hand to help test / release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #920
re processing/p5.js#4982, following up from #931
Changes
mainbranch