Fixed imagemin compression #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@limzykenneth Hi, can you please review my PR |
Member
limzykenneth
left a comment
limzykenneth
left a comment
There was a problem hiding this comment.
Just one edit suggestion. After that should be ready to merge. We can potentially optimize a bit more by resizing the images but it doesn't need to be done now.
Co-authored-by: Kenneth Lim <[email protected]>
Member
|
Looks good. Thanks. |
Contributor
Author
|
Thanks @limzykenneth 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927
Changes:
Added imagemin plugins for jpeg and png image compression. One can learn about it here
Screenshots of the change:
Before Changes :
The images were of large size and were taking a few seconds to load on browser. The imagemin plugin was not compressing the images (refer the screenshot below)
After Changes :
Added required additional imagemin plugins and now images are compressed and loading quick (refer the screenshot below)
Compression Results
