-
-
Notifications
You must be signed in to change notification settings - Fork 474
#906- Added Copy button on get-started page to copy different example texts and cdn link #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge commits from main repo to the forked repo
|
|
||
| </code></pre> | ||
| <div class="edit_space"> | ||
| <button id="copy_sketch1" class="copy_button">Copy</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the word "Copy" should go in the .yml files so it can be translated across languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only need to add this in the en.yml file right? Because I am not very familiar with the other languages
|
I'm not 100% sure about the position of the button, it looks a bit out of place there and also potentially blocking part of the scrollbar (which someone may want to click on that portion of the scrollbar). |
|
@limzykenneth I have taken the placement of the button from the examples section webpage. In examples section all the buttons were placed on the bottom right side of the code, hence I followed a similar convention here. If changes are required I'll do them. Thanks! |
|
For the examples, all of then have an associated sketch and the buttons are overlapped on the sketch instead of the code which is less of a problem. |
|
@lmccart @limzykenneth I have made the above-mentioned changes, please have a look. Thanks! |
Fixes #906
Changes:
Added buttons to copy the text of different example texts and cdn links.
Screenshots of the change:



Tagging @lmccart for review. Thanks!