Skip to content

Conversation

@rt1301
Copy link
Contributor

@rt1301 rt1301 commented Dec 19, 2020

Fixes #906

Changes:
Added buttons to copy the text of different example texts and cdn links.

Screenshots of the change:
Screenshot from 2020-12-19 17-25-33
Screenshot from 2020-12-19 17-26-36
copy_button

Tagging @lmccart for review. Thanks!

rt1301 and others added 2 commits December 16, 2020 12:23

</code></pre>
<div class="edit_space">
<button id="copy_sketch1" class="copy_button">Copy</button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word "Copy" should go in the .yml files so it can be translated across languages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only need to add this in the en.yml file right? Because I am not very familiar with the other languages

@limzykenneth
Copy link
Member

I'm not 100% sure about the position of the button, it looks a bit out of place there and also potentially blocking part of the scrollbar (which someone may want to click on that portion of the scrollbar).

@rt1301
Copy link
Contributor Author

rt1301 commented Dec 19, 2020

@limzykenneth I have taken the placement of the button from the examples section webpage. In examples section all the buttons were placed on the bottom right side of the code, hence I followed a similar convention here. If changes are required I'll do them. Thanks!

@limzykenneth
Copy link
Member

For the examples, all of then have an associated sketch and the buttons are overlapped on the sketch instead of the code which is less of a problem.

@rt1301 rt1301 requested a review from lmccart December 21, 2020 19:40
@rt1301
Copy link
Contributor Author

rt1301 commented Dec 21, 2020

@lmccart @limzykenneth I have made the above-mentioned changes, please have a look. Thanks!

@rt1301 rt1301 requested a review from limzykenneth December 27, 2020 18:06
@lmccart lmccart merged commit 1c67bbb into processing:main Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need copy to clipboard button on get started page

3 participants