Detecting default language preference of user & translating #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@limzykenneth @lmccart can you please review it! 🙂 |
limzykenneth
approved these changes
Nov 30, 2020
Member
|
thanks @CovalentBond! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #897
Changes:
The function was already present, but was not working
langs=["en", "es", "ko", "zh-Hans"]While debugging found that, it was not going inside the for loop and due to which it could not return the
langs[i]Screenshots of the change:
Now as shown below, if the language preference will be present.
It will show in the set browser's language only, unless manually updated.