Fixing test in monoSynth.js #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therewasaguy
requested changes
Apr 25, 2021
|
@therewasaguy fixed and test passes. Ready for merge :) |
|
@therewasaguy can you please!! review this. |
therewasaguy
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@therewasaguy The freq of note 'A2' is 55 but we are checking in test 110.
we can test 110 by
monoSynth.oscillator.freq(110,0.001);and then in expect we can do
expect(monoSynth.oscillator.freq().value).to.equal(110);but I think 55 is also good
This test fails sometime because it compares the default value to 55 if you run the test multiple times I think it is due to Mocha running the function rightaway and our frequency is not set yet.
screenshot
of the passing test